// Copyright 2013 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. // This file contains the code to check that locks are not passed by value. package main import ( "bytes" "fmt" "go/ast" "go/token" "go/types" ) func init() { register("copylocks", "check that locks are not passed by value", checkCopyLocks, funcDecl, rangeStmt, funcLit) } // checkCopyLocks checks whether node might // inadvertently copy a lock. func checkCopyLocks(f *File, node ast.Node) { switch node := node.(type) { case *ast.RangeStmt: checkCopyLocksRange(f, node) case *ast.FuncDecl: checkCopyLocksFunc(f, node.Name.Name, node.Recv, node.Type) case *ast.FuncLit: checkCopyLocksFunc(f, "func", nil, node.Type) } } // checkCopyLocksFunc checks whether a function might // inadvertently copy a lock, by checking whether // its receiver, parameters, or return values // are locks. func checkCopyLocksFunc(f *File, name string, recv *ast.FieldList, typ *ast.FuncType) { if recv != nil && len(recv.List) > 0 { expr := recv.List[0].Type if path := lockPath(f.pkg.typesPkg, f.pkg.types[expr].Type); path != nil { f.Badf(expr.Pos(), "%s passes Lock by value: %v", name, path) } } if typ.Params != nil { for _, field := range typ.Params.List { expr := field.Type if path := lockPath(f.pkg.typesPkg, f.pkg.types[expr].Type); path != nil { f.Badf(expr.Pos(), "%s passes Lock by value: %v", name, path) } } } if typ.Results != nil { for _, field := range typ.Results.List { expr := field.Type if path := lockPath(f.pkg.typesPkg, f.pkg.types[expr].Type); path != nil { f.Badf(expr.Pos(), "%s returns Lock by value: %v", name, path) } } } } // checkCopyLocksRange checks whether a range statement // might inadvertently copy a lock by checking whether // any of the range variables are locks. func checkCopyLocksRange(f *File, r *ast.RangeStmt) { checkCopyLocksRangeVar(f, r.Tok, r.Key) checkCopyLocksRangeVar(f, r.Tok, r.Value) } func checkCopyLocksRangeVar(f *File, rtok token.Token, e ast.Expr) { if e == nil { return } id, isId := e.(*ast.Ident) if isId && id.Name == "_" { return } var typ types.Type if rtok == token.DEFINE { if !isId { return } obj := f.pkg.defs[id] if obj == nil { return } typ = obj.Type() } else { typ = f.pkg.types[e].Type } if typ == nil { return } if path := lockPath(f.pkg.typesPkg, typ); path != nil { f.Badf(e.Pos(), "range var %s copies Lock: %v", f.gofmt(e), path) } } type typePath []types.Type // String pretty-prints a typePath. func (path typePath) String() string { n := len(path) var buf bytes.Buffer for i := range path { if i > 0 { fmt.Fprint(&buf, " contains ") } // The human-readable path is in reverse order, outermost to innermost. fmt.Fprint(&buf, path[n-i-1].String()) } return buf.String() } // lockPath returns a typePath describing the location of a lock value // contained in typ. If there is no contained lock, it returns nil. func lockPath(tpkg *types.Package, typ types.Type) typePath { if typ == nil { return nil } // We're only interested in the case in which the underlying // type is a struct. (Interfaces and pointers are safe to copy.) styp, ok := typ.Underlying().(*types.Struct) if !ok { return nil } // We're looking for cases in which a reference to this type // can be locked, but a value cannot. This differentiates // embedded interfaces from embedded values. if plock := types.NewMethodSet(types.NewPointer(typ)).Lookup(tpkg, "Lock"); plock != nil { if lock := types.NewMethodSet(typ).Lookup(tpkg, "Lock"); lock == nil { return []types.Type{typ} } } nfields := styp.NumFields() for i := 0; i < nfields; i++ { ftyp := styp.Field(i).Type() subpath := lockPath(tpkg, ftyp) if subpath != nil { return append(subpath, typ) } } return nil }