/* * Copyright (C) 2017 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ #include "perfetto/protozero/message.h" #include "perfetto/protozero/message_handle.h" #include <limits> #include <memory> #include <utility> #include <vector> #include "gtest/gtest.h" #include "perfetto/base/logging.h" #include "src/base/test/utils.h" #include "src/protozero/test/fake_scattered_buffer.h" namespace protozero { namespace { constexpr size_t kChunkSize = 16; constexpr uint8_t kTestBytes[] = {0, 0, 0, 0, 0x42, 1, 0x42, 0xff, 0x42, 0}; constexpr const char kStartWatermark[] = {'a', 'b', 'c', 'd', '1', '2', '3', '\0'}; constexpr const char kEndWatermark[] = {'9', '8', '7', '6', 'z', 'w', 'y', '\0'}; class FakeRootMessage : public Message {}; class FakeChildMessage : public Message {}; uint32_t SimpleHash(const std::string& str) { uint32_t hash = 5381; for (char c : str) hash = 33 * hash + static_cast<uint32_t>(c); return hash; } class MessageTest : public ::testing::Test { public: void SetUp() override { buffer_.reset(new FakeScatteredBuffer(kChunkSize)); stream_writer_.reset(new ScatteredStreamWriter(buffer_.get())); readback_pos_ = 0; } void TearDown() override { // Check that none of the messages created by the text fixtures below did // under/overflow their heap boundaries. for (std::unique_ptr<uint8_t[]>& mem : messages_) { EXPECT_STREQ(kStartWatermark, reinterpret_cast<char*>(mem.get())); EXPECT_STREQ(kEndWatermark, reinterpret_cast<char*>(mem.get() + sizeof(kStartWatermark) + sizeof(Message))); mem.reset(); } messages_.clear(); stream_writer_.reset(); buffer_.reset(); } void ResetMessage(FakeRootMessage* msg) { msg->Reset(stream_writer_.get()); } FakeRootMessage* NewMessage() { std::unique_ptr<uint8_t[]> mem( new uint8_t[sizeof(kStartWatermark) + sizeof(FakeRootMessage) + sizeof(kEndWatermark)]); uint8_t* msg_start = mem.get() + sizeof(kStartWatermark); memcpy(mem.get(), kStartWatermark, sizeof(kStartWatermark)); memset(msg_start, 0, sizeof(FakeRootMessage)); memcpy(msg_start + sizeof(FakeRootMessage), kEndWatermark, sizeof(kEndWatermark)); messages_.push_back(std::move(mem)); FakeRootMessage* msg = reinterpret_cast<FakeRootMessage*>(msg_start); msg->Reset(stream_writer_.get()); return msg; } size_t GetNumSerializedBytes() { if (buffer_->chunks().empty()) return 0; return buffer_->chunks().size() * kChunkSize - stream_writer_->bytes_available(); } std::string GetNextSerializedBytes(size_t num_bytes) { size_t old_readback_pos = readback_pos_; readback_pos_ += num_bytes; return buffer_->GetBytesAsString(old_readback_pos, num_bytes); } static void BuildNestedMessages(Message* msg, uint32_t depth = 0) { for (uint32_t i = 1; i <= 128; ++i) msg->AppendBytes(i, kTestBytes, sizeof(kTestBytes)); if (depth < Message::kMaxNestingDepth) { auto* nested_msg = msg->BeginNestedMessage<FakeChildMessage>(1 + depth * 10); BuildNestedMessages(nested_msg, depth + 1); } for (uint32_t i = 129; i <= 256; ++i) msg->AppendVarInt(i, 42); if ((depth & 2) == 0) msg->Finalize(); } private: std::unique_ptr<FakeScatteredBuffer> buffer_; std::unique_ptr<ScatteredStreamWriter> stream_writer_; std::vector<std::unique_ptr<uint8_t[]>> messages_; size_t readback_pos_; }; TEST_F(MessageTest, ZeroLengthArraysAndStrings) { Message* msg = NewMessage(); msg->AppendBytes(1 /* field_id */, nullptr, 0); msg->AppendString(2 /* field_id */, ""); EXPECT_EQ(4u, msg->Finalize()); EXPECT_EQ(4u, GetNumSerializedBytes()); // These lines match the serialization of the Append* calls above. ASSERT_EQ("0A00", GetNextSerializedBytes(2)); ASSERT_EQ("1200", GetNextSerializedBytes(2)); } TEST_F(MessageTest, BasicTypesNoNesting) { Message* msg = NewMessage(); msg->AppendVarInt(1 /* field_id */, 0); msg->AppendVarInt(2 /* field_id */, std::numeric_limits<uint32_t>::max()); msg->AppendVarInt(3 /* field_id */, 42); msg->AppendVarInt(4 /* field_id */, std::numeric_limits<uint64_t>::max()); msg->AppendFixed(5 /* field_id */, 3.1415f /* float */); msg->AppendFixed(6 /* field_id */, 3.14159265358979323846 /* double */); msg->AppendBytes(7 /* field_id */, kTestBytes, sizeof(kTestBytes)); // Field ids > 16 are expected to be varint encoded (preamble > 1 byte) msg->AppendString(257 /* field_id */, "0123456789abcdefABCDEF"); msg->AppendSignedVarInt(3 /* field_id */, -21); EXPECT_EQ(74u, msg->Finalize()); EXPECT_EQ(74u, GetNumSerializedBytes()); // These lines match the serialization of the Append* calls above. ASSERT_EQ("0800", GetNextSerializedBytes(2)); ASSERT_EQ("10FFFFFFFF0F", GetNextSerializedBytes(6)); ASSERT_EQ("182A", GetNextSerializedBytes(2)); ASSERT_EQ("20FFFFFFFFFFFFFFFFFF01", GetNextSerializedBytes(11)); ASSERT_EQ("2D560E4940", GetNextSerializedBytes(5)); ASSERT_EQ("31182D4454FB210940", GetNextSerializedBytes(9)); ASSERT_EQ("3A0A00000000420142FF4200", GetNextSerializedBytes(12)); ASSERT_EQ("8A101630313233343536373839616263646566414243444546", GetNextSerializedBytes(25)); ASSERT_EQ("1829", GetNextSerializedBytes(2)); } TEST_F(MessageTest, NestedMessagesSimple) { Message* root_msg = NewMessage(); root_msg->AppendVarInt(1 /* field_id */, 1); FakeChildMessage* nested_msg = root_msg->BeginNestedMessage<FakeChildMessage>(128 /* field_id */); ASSERT_EQ(0u, reinterpret_cast<uintptr_t>(nested_msg) % sizeof(void*)); nested_msg->AppendVarInt(2 /* field_id */, 2); nested_msg = root_msg->BeginNestedMessage<FakeChildMessage>(129 /* field_id */); nested_msg->AppendVarInt(4 /* field_id */, 2); root_msg->AppendVarInt(5 /* field_id */, 3); // The expected size of the root message is supposed to be 20 bytes: // 2 bytes for the varint field (id: 1) (1 for preamble and one for payload) // 6 bytes for the preamble of the 1st nested message (2 for id, 4 for size) // 2 bytes for the varint field (id: 2) of the 1st nested message // 6 bytes for the premable of the 2nd nested message // 2 bytes for the varint field (id: 4) of the 2nd nested message. // 2 bytes for the last varint (id : 5) field of the root message. // Test also that finalization is idempontent and Finalize() can be safely // called more than once without side effects. for (int i = 0; i < 3; ++i) { EXPECT_EQ(20u, root_msg->Finalize()); EXPECT_EQ(20u, GetNumSerializedBytes()); } ASSERT_EQ("0801", GetNextSerializedBytes(2)); ASSERT_EQ("820882808000", GetNextSerializedBytes(6)); ASSERT_EQ("1002", GetNextSerializedBytes(2)); ASSERT_EQ("8A0882808000", GetNextSerializedBytes(6)); ASSERT_EQ("2002", GetNextSerializedBytes(2)); ASSERT_EQ("2803", GetNextSerializedBytes(2)); } // Tests using a AppendScatteredBytes to append raw bytes to // a message using multiple individual buffers. TEST_F(MessageTest, AppendScatteredBytes) { Message* root_msg = NewMessage(); uint8_t buffer[42]; memset(buffer, 0x42, sizeof(buffer)); ContiguousMemoryRange ranges[] = {{buffer, buffer + sizeof(buffer)}, {buffer, buffer + sizeof(buffer)}}; root_msg->AppendScatteredBytes(1 /* field_id */, ranges, 2); EXPECT_EQ(86u, root_msg->Finalize()); EXPECT_EQ(86u, GetNumSerializedBytes()); // field_id EXPECT_EQ("0A", GetNextSerializedBytes(1)); // field length EXPECT_EQ("54", GetNextSerializedBytes(1)); // start of contents EXPECT_EQ("42424242", GetNextSerializedBytes(4)); } // Checks that the size field of root and nested messages is properly written // on finalization. TEST_F(MessageTest, BackfillSizeOnFinalization) { Message* root_msg = NewMessage(); uint8_t root_msg_size[proto_utils::kMessageLengthFieldSize] = {}; root_msg->set_size_field(&root_msg_size[0]); root_msg->AppendVarInt(1, 0x42); FakeChildMessage* nested_msg_1 = root_msg->BeginNestedMessage<FakeChildMessage>(2); nested_msg_1->AppendVarInt(3, 0x43); FakeChildMessage* nested_msg_2 = nested_msg_1->BeginNestedMessage<FakeChildMessage>(4); uint8_t buf200[200]; memset(buf200, 0x42, sizeof(buf200)); nested_msg_2->AppendBytes(5, buf200, sizeof(buf200)); root_msg->inc_size_already_written(6); // The value returned by Finalize() should be == the full size of |root_msg|. EXPECT_EQ(217u, root_msg->Finalize()); EXPECT_EQ(217u, GetNumSerializedBytes()); // However the size written in the size field should take into account the // inc_size_already_written() call and be equal to 118 - 6 = 112, encoded // in a rendundant varint encoding of kMessageLengthFieldSize bytes. EXPECT_STREQ("\xD3\x81\x80\x00", reinterpret_cast<char*>(root_msg_size)); // Skip 2 bytes for the 0x42 varint + 1 byte for the |nested_msg_1| preamble. GetNextSerializedBytes(3); // Check that the size of |nested_msg_1| was backfilled. Its size is: // 203 bytes for |nest_mesg_2| (see below) + 5 bytes for its preamble + // 2 bytes for the 0x43 varint = 210 bytes. EXPECT_EQ("D2818000", GetNextSerializedBytes(4)); // Skip 2 bytes for the 0x43 varint + 1 byte for the |nested_msg_2| preamble. GetNextSerializedBytes(3); // Check that the size of |nested_msg_2| was backfilled. Its size is: // 200 bytes (for |buf200|) + 3 bytes for its preamble = 203 bytes. EXPECT_EQ("CB818000", GetNextSerializedBytes(4)); } TEST_F(MessageTest, StressTest) { std::vector<Message*> nested_msgs; Message* root_msg = NewMessage(); BuildNestedMessages(root_msg); root_msg->Finalize(); // The main point of this test is to stress the code paths and test for // unexpected crashes of the production code. The actual serialization is // already covered in the other text fixtures. Keeping just a final smoke test // here on the full buffer hash. std::string full_buf = GetNextSerializedBytes(GetNumSerializedBytes()); size_t buf_hash = SimpleHash(full_buf); EXPECT_EQ(0xf9e32b65, buf_hash); } TEST_F(MessageTest, DestructInvalidMessageHandle) { FakeRootMessage* msg = NewMessage(); EXPECT_DCHECK_DEATH( { MessageHandle<FakeRootMessage> handle(msg); ResetMessage(msg); }); } TEST_F(MessageTest, MessageHandle) { FakeRootMessage* msg1 = NewMessage(); FakeRootMessage* msg2 = NewMessage(); FakeRootMessage* msg3 = NewMessage(); FakeRootMessage* ignored_msg = NewMessage(); uint8_t msg1_size[proto_utils::kMessageLengthFieldSize] = {}; uint8_t msg2_size[proto_utils::kMessageLengthFieldSize] = {}; uint8_t msg3_size[proto_utils::kMessageLengthFieldSize] = {}; msg1->set_size_field(&msg1_size[0]); msg2->set_size_field(&msg2_size[0]); msg3->set_size_field(&msg3_size[0]); // Test that the handle going out of scope causes the finalization of the // target message and triggers the optional callback. { MessageHandle<FakeRootMessage> handle1(msg1); handle1->AppendBytes(1 /* field_id */, kTestBytes, 1 /* size */); ASSERT_EQ(0u, msg1_size[0]); } ASSERT_EQ(0x83u, msg1_size[0]); // Test that the handle can be late initialized. MessageHandle<FakeRootMessage> handle2(ignored_msg); handle2 = MessageHandle<FakeRootMessage>(msg2); handle2->AppendBytes(1 /* field_id */, kTestBytes, 2 /* size */); ASSERT_EQ(0u, msg2_size[0]); // |msg2| should not be finalized yet. // Test that std::move works and does NOT cause finalization of the moved // message. MessageHandle<FakeRootMessage> handle_swp(ignored_msg); handle_swp = std::move(handle2); ASSERT_EQ(0u, msg2_size[0]); // msg2 should be NOT finalized yet. handle_swp->AppendBytes(2 /* field_id */, kTestBytes, 3 /* size */); MessageHandle<FakeRootMessage> handle3(msg3); handle3->AppendBytes(1 /* field_id */, kTestBytes, 4 /* size */); ASSERT_EQ(0u, msg3_size[0]); // msg2 should be NOT finalized yet. // Both |handle3| and |handle_swp| point to a valid message (respectively, // |msg3| and |msg2|). Now move |handle3| into |handle_swp|. handle_swp = std::move(handle3); ASSERT_EQ(0x89u, msg2_size[0]); // |msg2| should be finalized at this point. // At this point writing into handle_swp should actually write into |msg3|. ASSERT_EQ(msg3, &*handle_swp); handle_swp->AppendBytes(2 /* field_id */, kTestBytes, 8 /* size */); MessageHandle<FakeRootMessage> another_handle(ignored_msg); handle_swp = std::move(another_handle); ASSERT_EQ(0x90u, msg3_size[0]); // |msg3| should be finalized at this point. #if PERFETTO_DCHECK_IS_ON() // In developer builds w/ PERFETTO_DCHECK on a finalized message should // invalidate the handle, in order to early catch bugs in the client code. FakeRootMessage* msg4 = NewMessage(); MessageHandle<FakeRootMessage> handle4(msg4); ASSERT_EQ(msg4, &*handle4); msg4->Finalize(); ASSERT_EQ(nullptr, &*handle4); #endif // Test also the behavior of handle with non-root (nested) messages. uint8_t* size_msg_2; { auto* nested_msg_1 = NewMessage()->BeginNestedMessage<FakeChildMessage>(3); MessageHandle<FakeChildMessage> child_handle_1(nested_msg_1); uint8_t* size_msg_1 = nested_msg_1->size_field(); memset(size_msg_1, 0, proto_utils::kMessageLengthFieldSize); child_handle_1->AppendVarInt(1, 0x11); auto* nested_msg_2 = NewMessage()->BeginNestedMessage<FakeChildMessage>(2); size_msg_2 = nested_msg_2->size_field(); memset(size_msg_2, 0, proto_utils::kMessageLengthFieldSize); MessageHandle<FakeChildMessage> child_handle_2(nested_msg_2); child_handle_2->AppendVarInt(2, 0xFF); // |nested_msg_1| should not be finalized yet. ASSERT_EQ(0u, size_msg_1[0]); // This move should cause |nested_msg_1| to be finalized, but not // |nested_msg_2|, which will be finalized only after the current scope. child_handle_1 = std::move(child_handle_2); ASSERT_EQ(0x82u, size_msg_1[0]); ASSERT_EQ(0u, size_msg_2[0]); } ASSERT_EQ(0x83u, size_msg_2[0]); } TEST_F(MessageTest, MoveMessageHandle) { FakeRootMessage* msg = NewMessage(); uint8_t msg_size[proto_utils::kMessageLengthFieldSize] = {}; msg->set_size_field(&msg_size[0]); // Test that the handle going out of scope causes the finalization of the // target message. { MessageHandle<FakeRootMessage> handle1(msg); MessageHandle<FakeRootMessage> handle2{}; handle1->AppendBytes(1 /* field_id */, kTestBytes, 1 /* size */); handle2 = std::move(handle1); ASSERT_EQ(0u, msg_size[0]); } ASSERT_EQ(0x83u, msg_size[0]); } } // namespace } // namespace protozero